Skip to content

feature/md-2157-forward-client-ip-cdn-proxies - #30

Merged
filipe-boleto merged 1 commit into
mainfrom
feature/md-2157-forward-client-ip-cdn-proxies
Jul 23, 2026
Merged

filipe-boleto merged 1 commit into
mainfrom
feature/md-2157-forward-client-ip-cdn-proxies

Conversation

@filipe-boleto

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented Jul 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9a48c30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@monetizationos/proxy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@filipe-boleto
filipe-boleto force-pushed the feature/md-2157-forward-client-ip-cdn-proxies branch from 028e9bb to 2c7c716 Compare July 16, 2026 00:19
@filipe-boleto
filipe-boleto requested a review from Copilot July 16, 2026 00:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Forwards CDN-derived client IPs to MOS API requests.

Changes:

  • Adds Cloudflare, Fastly, and Akamai IP resolution.
  • Includes http.clientIP in surface decisions and authenticated API payloads.
  • Adds tests and release metadata.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/resolveHttpClientIp.ts Resolves CDN client IPs.
src/stages/surfaceDecisions.ts Supplies resolved IP to decisions.
src/stages/fetchSurfaceDecisions.ts Adds clientIP to payloads.
src/stages/mosAuthenticatedApi.ts Adds IP to authenticated requests.
test/resolveHttpClientIp.spec.ts Tests CDN resolution.
test/stages/fetchSurfaceDecisions.spec.ts Tests payload serialization.
test/MOSProxy.spec.ts Adds pipeline integration tests.
package.json Bumps package version.
src/apiRequestHeaders.ts Synchronizes proxy version header.
CHANGELOG.md Documents version 1.5.2.
.changeset/forward-client-ip.md Declares a patch release.

Comment thread src/resolveHttpClientIp.ts Outdated
Comment thread src/resolveHttpClientIp.ts Outdated
Comment thread package.json Outdated
@filipe-boleto
filipe-boleto force-pushed the feature/md-2157-forward-client-ip-cdn-proxies branch 6 times, most recently from 803aba3 to c6e4870 Compare July 16, 2026 09:38
@filipe-boleto
filipe-boleto requested review from JFL110 and benney July 16, 2026 11:05
@filipe-boleto
filipe-boleto marked this pull request as ready for review July 16, 2026 11:05

@benney benney left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes too many assumptions about platform specific shapes from an opaque blob of metadata.
Each CDN runtime already knows its client IP, so let's add something like .withClientIP((request) => ...) instead and pass that through as http.clientIP in the fetch handlers

@filipe-boleto
filipe-boleto force-pushed the feature/md-2157-forward-client-ip-cdn-proxies branch 2 times, most recently from ec739b6 to 285abba Compare July 17, 2026 07:55
@filipe-boleto
filipe-boleto requested a review from benney July 17, 2026 07:57
@benney
benney requested a review from Copilot July 21, 2026 13:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Comment thread src/MOSProxy.ts Outdated
@filipe-boleto
filipe-boleto force-pushed the feature/md-2157-forward-client-ip-cdn-proxies branch from 285abba to 9a48c30 Compare July 22, 2026 17:09
@filipe-boleto
filipe-boleto merged commit af4fe40 into main Jul 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants