Repository navigation
Accept Idempotency-Keys of 1 to 256 bytes on every route - #934
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pinned
Idempotency-KeyofPOST /agents/sessions/{session_id}/eventsis optional and takes 1–256 bytes. Core capped it at 128 bytes and replaced an empty header with a random key.sessions.ValidateIdempotencyKey: 1–256 bytes. It replaces the three copies (events, Session creation, standalone Environment creation) and the whitespace check, which never applied over HTTP because header values arrive trimmed.Idempotency-Key, keeps treating an empty header as no key and now takes up to 256 bytes.wire-semantics.md,sessions-events.md,public-agent-api.md.Checks
go vet ./...; tests ofsessions,api,execution,automationsand the integration subset for keys, events, inputs, creation and Automations pass with a database.pnpm --dir website check-translationspasses.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.