Skip to content

Keep layout and wrapping preferences across all reviews - #51

Merged
rcosteira79 merged 2 commits into
mainfrom
fix/persist-review-view-preferences
Nov 12, 2026
Merged

rcosteira79 merged 2 commits into
mainfrom
fix/persist-review-view-preferences

Conversation

@rcosteira79

@rcosteira79 rcosteira79 commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Split/Unified and Scroll/Wrap were saved per worktree path, so new worktrees reverted to defaults. Resuming an older review also restored its stale view choices over newer saved settings.

Make layout and wrapping global reviewer preferences, with separate desktop and mobile choices. New and resumed reviews use the latest defaults; existing repository/session choices migrate per device when opened. Preserve compatibility with older running reviews, keep failed saves from undoing newer choices, and allow server-side persistence when browser storage is unavailable.

Validation:

  • Session regressions reproduce the previous failures and pass with the fix.
  • Browser regression passes across different repositories, server ports, stale sessions, desktop/mobile views, and unavailable browser preference storage.
  • bun run verify: typecheck, 1,196 passing tests (13 skipped), and JavaScript syntax checks.
  • All CI checks pass on the final commit, including Windows and every Monaco browser group.

@rcosteira79
rcosteira79 merged commit b5f4fc4 into main Nov 12, 2026
14 checks passed
@rcosteira79 rcosteira79 mentioned this pull request Nov 13, 2026
@rcosteira79
rcosteira79 deleted the fix/persist-review-view-preferences branch November 13, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant