Repository navigation
Fix stop comment form remaining disabled after saving - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After saving a tour-stop comment, the persistent form kept its submit button disabled. Opening it on another stop (or editing an existing comment) therefore could not submit again.
Always re-enable the button when the save request finishes. Extend the browser regression to save comments on two different stops, edit the original comment, and retry a failed save without losing its draft.
Validation:
bun run verify: typecheck, 1,191 passing tests (13 skipped), and JavaScript syntax checks. The run requires localhost networking for server fixtures.