Skip to content

Show only supplied media by default - #45

Merged
rcosteira79 merged 3 commits into
mainfrom
fix/curated-media-default
Nov 10, 2026
Merged

rcosteira79 merged 3 commits into
mainfrom
fix/curated-media-default

Conversation

@rcosteira79

Copy link
Copy Markdown
Collaborator

Media now shows only files supplied with --media by default, and hides the tab when none were supplied. A review with two QA captures and 60 modified PNGs therefore shows Media 2, while each changed PNG remains reviewable in Changes with its before/after comparison.

Add --media-include-changed-images or .diffcompass.json → media.includeChangedImages: true to include diff images in Media. That example then shows Media 122. These optional images load only when their cards enter the viewport or are explicitly opened; a hidden Media tab does not fetch them. Renders share pending requests and discard stale results.

Persist the choice with the session. The explicit flag overrides a saved choice, and a saved choice overrides repository defaults. Existing sessions without the field use the default false unless the repository explicitly opts in. Media imports, authentication, the PR launch path and before/after image review remain intact.

Validation:

  • bun run verify: 1,181 passed, 13 skipped, no failures.
  • Browser checks with 60 changed PNGs: counts 2/0 by default and 122/120 with opt-in, hidden empty tab, lazy viewport and explicit loads, and the original Changes comparison.
  • Real CLI sessions verify defaults, CLI/config precedence, persisted choices and unchanged imported media across resume; the PR command accepts the flag.
  • Production CLI compilation and help output passed; configuration and persistence reject non-boolean values.

@rcosteira79
rcosteira79 merged commit c428e89 into main Nov 10, 2026
14 checks passed
@rcosteira79
rcosteira79 deleted the fix/curated-media-default branch November 13, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant