Repository navigation
Show only supplied media by default - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media now shows only files supplied with
--mediaby default, and hides the tab when none were supplied. A review with two QA captures and 60 modified PNGs therefore shows Media 2, while each changed PNG remains reviewable in Changes with its before/after comparison.Add
--media-include-changed-imagesor.diffcompass.json→media.includeChangedImages: trueto include diff images in Media. That example then shows Media 122. These optional images load only when their cards enter the viewport or are explicitly opened; a hidden Media tab does not fetch them. Renders share pending requests and discard stale results.Persist the choice with the session. The explicit flag overrides a saved choice, and a saved choice overrides repository defaults. Existing sessions without the field use the default false unless the repository explicitly opts in. Media imports, authentication, the PR launch path and before/after image review remain intact.
Validation:
bun run verify: 1,181 passed, 13 skipped, no failures.