Repository navigation
Port Skra expiration tracking and IT Glue sign-in redirect fix from personal fork - #1
MTG-Thomas wants to merge 6 commits into
Conversation
(cherry picked from commit 18d708b)
Ported from Skra. Originally 53daaba (#5) in MTG-Thomas/bifrost-docs-solution. Changes from the original: the secret-exclusion test uses a named sentinel instead of a password-shaped literal (secret scanners flagged it), and the incidental @emnapi package-lock churn is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Brought up to date with Still on hold for #2. Once Docs is opted into auto-sync (Midtown-Technology-Group/bifrost-solution-gitops#3), merging this deploys it to production. |
Moves the work merged in
MTG-Thomas/bifrost-docs-solution(being archived) ontomtg, the branch the Bifrost Docs install follows.What's included
main= upstream 0.1.3, proposable upstream)feat/expiration-tracking— tenant-scoped asset expiration tracking:docs_list_expirationsworkflow, dashboard widget, opt-in date fields53daaba)fix/itglue-attachment-sign-in-redirects— detect IT Glue attachment downloads that redirect to sign-in instead of returning the file18d708b, cherry-picked with-x)The personal fork's content is the same apart from two deliberate changes to the expiration commit:
"password": "do-not-return". ggshield flagged that literal as a generic password. It was a false positive, but the outgoing range should scan clean.@emnapipackage-lock entries that came from a different npm version. The lockfile stays on themtgside, which already has the DOMPurify/Vite/Vitest security bumps.Verification (merged tree, local)
npm --prefix apps/bifrost-docs test: 41 files, 314 tests passed.npm --prefix apps/bifrost-docs run build: succeeded.pytest tests(python:3.13-slim withrequirements.txtand the CLI'sbifrostSDK onPYTHONPATH): 359 passed, 1 failed.test_publication_portability, already fails onmtg. It pinsvitestto^4.1.11, andfdaec5cchanged it to4.1.12. That will be fixed separately.ggshield secret scan commit-range mtg..HEAD: exit 0.Before deploying
Hold
bifrost solution syncuntil the pending authorization-hardening change for Solution workflows is ready. Deploy this with it rather than on its own.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.