Skip to content

Port Skra expiration tracking and IT Glue sign-in redirect fix from personal fork - #1

Open
MTG-Thomas wants to merge 6 commits into
mtgfrom
port/personal-fork-into-mtg
Open

MTG-Thomas wants to merge 6 commits into
mtgfrom
port/personal-fork-into-mtg

Conversation

@MTG-Thomas

@MTG-Thomas MTG-Thomas commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Moves the work merged in MTG-Thomas/bifrost-docs-solution (being archived) onto mtg, the branch the Bifrost Docs install follows.

What's included

Branch (based on main = upstream 0.1.3, proposable upstream) Original
feat/expiration-tracking — tenant-scoped asset expiration tracking: docs_list_expirations workflow, dashboard widget, opt-in date fields MTG-Thomas#5 (53daaba)
fix/itglue-attachment-sign-in-redirects — detect IT Glue attachment downloads that redirect to sign-in instead of returning the file MTG-Thomas#6 (18d708b, cherry-picked with -x)

The personal fork's content is the same apart from two deliberate changes to the expiration commit:

  • The secret-exclusion test now uses a named sentinel instead of "password": "do-not-return". ggshield flagged that literal as a generic password. It was a false positive, but the outgoing range should scan clean.
  • Dropped the incidental @emnapi package-lock entries that came from a different npm version. The lockfile stays on the mtg side, which already has the DOMPurify/Vite/Vitest security bumps.

Verification (merged tree, local)

  • npm --prefix apps/bifrost-docs test: 41 files, 314 tests passed.
  • npm --prefix apps/bifrost-docs run build: succeeded.
  • pytest tests (python:3.13-slim with requirements.txt and the CLI's bifrost SDK on PYTHONPATH): 359 passed, 1 failed.
    • The failing test, test_publication_portability, already fails on mtg. It pins vitest to ^4.1.11, and fdaec5c changed it to 4.1.12. That will be fixed separately.
  • ggshield secret scan commit-range mtg..HEAD: exit 0.

Before deploying

Hold bifrost solution sync until the pending authorization-hardening change for Solution workflows is ready. Deploy this with it rather than on its own.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

MTG-Thomas and others added 4 commits November 16, 2026 11:22
Ported from Skra. Originally 53daaba (#5) in MTG-Thomas/bifrost-docs-solution.
Changes from the original: the secret-exclusion test uses a named sentinel
instead of a password-shaped literal (secret scanners flagged it), and the
incidental @emnapi package-lock churn is dropped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e4d18537-220c-4819-aa44-6d2b9df24c29

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

MTG-Thomas and others added 2 commits November 16, 2026 13:14
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MTG-Thomas

Copy link
Copy Markdown
Member Author

Brought up to date with mtg (CI and test tooling from #27) and versioned 0.1.3+mtg.1. All required checks pass (python-tests, app-tests, version-policy).

Still on hold for #2. Once Docs is opted into auto-sync (Midtown-Technology-Group/bifrost-solution-gitops#3), merging this deploys it to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant