Skip to content

Make the documented test commands work, and unpin the brittle portability assertion #4

Closed

Description

@MTG-Thomas

Running the README's checks on a clean machine doesn't work as documented:

  • The Python command installs only pytest pyyaml. Collection fails without requirements.txt (httpx) and without the bifrost Python SDK; the README doesn't say where to get the SDK.
    • What worked: python:3.13-slim plus pip install pytest pyyaml pytest-asyncio pydantic -r requirements.txt, with the CLI's installed bifrost package on PYTHONPATH.
  • tests/test_publication_portability.py asserts vitest == "^4.1.11" in package.json and the lockfile. Any dependency bump breaks it. It already fails on mtg after the Vitest 4.1.12 security bump.
  • npm test needs bifrost solution sdk update . --app bifrost-docs first. Note that this needs a bound and authenticated instance.

Done when: a fresh clone passes the documented commands, the portability test checks the property (no instance SDK or private artifacts) rather than exact versions, and the fix goes upstream.

Activity

  1. added
    priority: nowDo first: security, cutover blockers, deploy hygiene
    upstream-candidateGeneric enough to propose to gobifrost/docs
    on Nov 16, 2026
  2. MTG-Thomas commented on Nov 16, 2026

    @MTG-Thomas
    MemberAuthor

    Scope addition: test_publication_portability.py also asserts descriptor["version"] == "0.1.3". That blocks the +mtg.N versioning convention from #3. Replace exact-version asserts with property checks: the version parses as PEP 440, and there's no instance SDK or private artifacts. Propose the relaxed test upstream as well.

    Working CI recipe, with no credentials needed:

    • Python: pip install pytest pyyaml pytest-asyncio pydantic -r requirements.txt "$BIFROST_URL/api/cli/download/bifrost-cli.tar.gz". The instance serves its exact CLI/SDK sdist without authentication.
    • App: install the tarball from GET $BIFROST_URL/api/sdk/download (public; the same API-matched SDK solution sdk update uses) without saving it to package.json, then npm test and npm run build.
  3. added a commit that references this issue on Nov 16, 2026
  4. MTG-Thomas commented on Nov 16, 2026

    @MTG-Thomas
    MemberAuthor

    Fixed by #27, merged to mtg as 30003bc. The portability test now checks properties instead of exact versions, the README test commands work on a clean machine, and CI installs the instance-served SDKs. fix/test-tooling (8115643, based on upstream 1cfdfa3) can be proposed upstream separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: nowDo first: security, cutover blockers, deploy hygieneupstream-candidateGeneric enough to propose to gobifrost/docs

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions