Repository navigation
fix(input): prevent keyboard and mouse input collisions - #6792
Open
crazycat256 wants to merge 1 commit into
Open
crazycat256 wants to merge 1 commit into
crazycat256 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
SDL keyboard scancodes and mouse buttons can share the same numeric value. Freecam and GUIMove compared these values without checking the input type, allowing mouse clicks to trigger keyboard movement.
For example, using Zoom bound to mouse button 4 while Freecam is active could trigger left movement, since SDL scancode 4 also represents the physical A key (Q on AZERTY).
The fix compares both the input type and value in Freecam and GUIMove, so mouse buttons no longer trigger unrelated keyboard bindings. It also applies the same distinction to input state tracking and the Keyboard HUD.
Related issues
No matching issue found.
How Has This Been Tested?
By trying to reproduce the bug with and without the fix in both dev and prod environments.
Checklist: