Clear the enchantment name cache when resource packs reload - #6634
Open
dekrom wants to merge 1 commit into
Open
Conversation
crosby-moe
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Names#onResourcePacksReloadedclears seven of the eight caches.enchantmentKeyNamesis theone it misses, so enchantment names stay in the old language after a language change or a
resource pack reload. It is a
WeakHashMap, but the registry holds theResourceKeys, so theentries are not going anywhere on their own.
Related issues
None that I found.
How Has This Been Tested?
Not reproduced in game yet, it is just the one cache missing from the reload handler that clears
the other seven. Builds clean against current master.
Checklist: