Fixed bold italic fonts not being restored on restart

[dekrom]

Type of change

• Bug fix
• New feature

Description

FontFaceSetting saves the font type with toString() and loads it with valueOf.
FontInfo.Type overrides toString so BoldItalic writes out as "Bold Italic" with a space,
and valueOf("Bold Italic") throws, so the catch quietly resets you to the default font.

Picking a Bold Italic face therefore never survives a restart. There is already a
FontInfo.Type#fromString that handles both "Bold Italic" and "BoldItalic", the load path
just was not using it.

Also null checks the face before setting it, since FontFamily#get returns null for a type the
family does not have, and moved the default fallback to a single exit instead of the changed
flag.

Related issues

None that I found.

How Has This Been Tested?

Not reproduced in game yet. FontInfo.Type#toString returns "Bold Italic" with a space and
valueOf only accepts BoldItalic, so the load always throws for that one type. Builds clean
against current master.

Checklist:

• My code follows the style guidelines of this project.
• I have added comments to my code in more complex areas.
• I have tested the code in both development and production environments.