Fixed elytra fly bounce recasting when any living entity stops gliding - #6629
Open
dekrom wants to merge 1 commit into
Open
Fixed elytra fly bounce recasting when any living entity stops gliding#6629dekrom wants to merge 1 commit into
dekrom wants to merge 1 commit into
Conversation
crosby-moe
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
LivingEntityMixin#recastOnLandis injected intoisFallFlying, which everyLivingEntitycalls, but it has no check that the entity is the local player.
isGlidingHookright above itdoes exactly that check.
So when any remote player or mob stops gliding, the injection calls
Bounce.recastElytra(mc.player), which sends aSTART_FALL_FLYINGfor you, and then feedsthat result back as the other entity's
isFallFlyingreturn value withcir.setReturnValue(...).Adding the same guard the rest of the file uses keeps the recast on the local player where it
belongs.
Related issues
None that I found.
How Has This Been Tested?
Not reproduced in game yet, this is a missing guard rather than something I caught happening.
isFallFlyingruns for every living entity and the injection above it already guards onmc.player. Builds clean against current master.Checklist: