fix: hide "send back to review" button for non-approved posts - #5111
Draft
aseckin wants to merge 1 commit into
Draft
fix: hide "send back to review" button for non-approved posts#5111aseckin wants to merge 1 commit into
aseckin wants to merge 1 commit into
Conversation
The frontend visibility condition only checked `isUpcoming`, so the button showed on DRAFT/PENDING/REJECTED posts whose underlying question had a future open_time — but the backend `send_back_to_review` action requires `curation_status == APPROVED` and 400s otherwise. Add an `isApproved` guard so the button visibility matches the backend precondition. Fixes #3029 Co-authored-by: aseckin <3686968+aseckin@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
isApprovedguard to thesendBackToReviewvisibility condition inpost_dropdown_menu.tsxso the button only renders for posts that are actually eligible for the action.Previously the button showed whenever the post had a future
open_timeand the viewer was admin/curator, but the backendsend_back_to_reviewaction requirescuration_status == APPROVED. APENDING/DRAFT/REJECTEDpost whose question had a futureopen_timewould render the button, and clicking it would 400 on the server.Fixes #3029
Test plan
PENDINGpost whose underlying question has a futureopen_timeas an admin — verify "Send back to review" is no longer in the menuAPPROVEDupcoming post as an admin/curator — verify "Send back to review" still appears and worksAPPROVEDpost whoseopen_timehas already passed — verify button remains hiddenGenerated with Claude Code