Repository navigation
Fix Embedded Wallets client secret rotation and React Native useCoreKitKey guidance - #3074
Open
yashovardhan wants to merge 3 commits into
Open
yashovardhan wants to merge 3 commits into
yashovardhan wants to merge 3 commits into
Conversation
…itKey guidance Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two Embedded Wallets docs passages give developers wrong guidance that can cost users their wallets.
Project settings: client secret
React Native migration guide (v8 to v9)
useCoreKitKeyanduseSFAKey.@web3auth/react-native-sdk9.0.0 and 10.0.0 still implementuseCoreKitKey. When it is true,getFinalCommonPrivKey()returnscoreKitKey, which is the v8 wallet. Without it, the SDK returnsprivKey, a different wallet.useCoreKitKey: truein v8 must keep it, or existing users lose access to their funds.useSFAKeyis a Web SDK rename and is not a React Native option, so it stays removed.Reported on Builder Hub:
Made with Cursor