Skip to content

fix(SubNavBar): make Embedded Wallets sub-nav link keys unique - #3062

Open
farquadars wants to merge 1 commit into
MetaMask:mainfrom
farquadars:fix/subnavbar-duplicate-react-keys
Open

farquadars wants to merge 1 commit into
MetaMask:mainfrom
farquadars:fix/subnavbar-duplicate-react-keys

Conversation

@farquadars

@farquadars farquadars commented Sep 29, 2026 •

Copy link
Copy Markdown

Summary

Fixes duplicate React keys in the Embedded Wallets sub-navigation bar.

Problem

EMBEDDED_WALLETS_SUBNAV_CONFIG defined three separate navigation links that all used the same key:

{ key: 'connect-blockchain', label: 'EVM', path: '/embedded-wallets/connect-blockchain/evm/' },
{ key: 'connect-blockchain', label: 'Solana', path: '/embedded-wallets/connect-blockchain/solana/' },
{ key: 'connect-blockchain', label: 'Other Blockchains', path: '/embedded-wallets/connect-blockchain/other/' },

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Config-only change to React list keys with no routing or navigation behavior changes.
> 
> **Overview**
> Fixes duplicate React list keys in the Embedded Wallets sub-navigation config. The EVM, Solana, and **Other Blockchains** entries previously shared `key: 'connect-blockchain'`; each now has a distinct key (`connect-blockchain-evm`, `connect-blockchain-solana`, `connect-blockchain-other`). **Labels and URLs are unchanged**—only the keys used when rendering the sub-nav link list are updated.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 694dd0342033ad30c482d33c689f87b65ea7fc46. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

@farquadars
farquadars requested review from a team as code owners September 29, 2026 18:36
@vercel

vercel Bot commented Sep 29, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Consensys Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant