fix(kyc-controller): Send residenceCountry and sessionClientPublicKey on kyc session creation - #9993
Open
jiexi wants to merge 4 commits into
Open
fix(kyc-controller): Send residenceCountry and sessionClientPublicKey on kyc session creation#9993jiexi wants to merge 4 commits into
jiexi wants to merge 4 commits into
Conversation
jiexi
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Breaking API on UKYC session creation and changes to crypto/session registration on the KYC critical path; controller orchestration is updated with reset guards.
Overview
BREAKING:
KycService.createUkycSession(POST /sessions) now requiressessionClientPublicKey(unpadded base64url X25519) andresidenceCountry(ISO 3166-1 alpha-3). Callers that invoke the service directly must supply both fields.KycControllergenerates a per-session X25519 keypair before creating the UKYC session, registers the public key with the API, and keeps the private key for wrappingdata_encryption_keyandukyc_capability_tokenviasetAuthorizations. Residence country comes from persistedgeoCountrywhen present, otherwise fromgetGeoCountry, with flow-generation checks so areset()during geo resolution does not create a session.Removes the unused
wrapUserKeyhelper and its tests;wrapEncryptionKeydocs now describe public-key registration on session creation rather than a separate wrapping-key exchange. Architecture docs, changelog, and tests cover the new payload and controller behavior.Reviewed by Cursor Bugbot for commit 965e373. Bugbot is set up for automated code reviews on this repo. Configure here.