fix(bridge): preserve Unified SwapBridge funnel metrics - #9986
Open
bfullam wants to merge 3 commits into
Open
Conversation
Capture sufficient-funds and explicit slippage context consistently across quote and post-submission events.
Align the slippage metrics test with the latest quote metadata API and restore linked unreleased changelog entries.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_sufficient_fundsto Unified SwapBridge Quotes Received metrics for SWAPS-4977.Test plan
yarn workspace @metamask/bridge-controller test --coverage=false --runInBand --testPathPatterns=src/utils/metrics/properties.test.tsyarn workspace @metamask/bridge-status-controller test --coverage=false --runInBand --testPathPatterns=src/utils/metrics.test.tsgit diff --checkNote
Low Risk
Changes are limited to analytics payloads and optional history metadata; swap/bridge execution logic is unchanged.
Overview
This PR tightens Unified SwapBridge analytics so quote-through-completion events carry consistent slippage and balance context.
In bridge-controller, Quotes Received now includes
has_sufficient_funds(from!insufficientBal),slippage_limitdefaults to0instead ofundefined(treating0as auto), andgetQuotesReceivedPropertiesaccepts optional client fallbacks forslippage_limit,custom_slippage, USD amount, and token symbols when the active quote is missing or incomplete.In bridge-status-controller, submit flows thread
quotesReceivedContextinto pre-submit and history creation socustom_slippageandslippage_limitmatch what the client captured at quote time;customSlippageis persisted on history items and used when rebuilding post-submit metrics, with legacy inference kept for Batch Sell and Quick Buy where explicit flags were not stored before.Reviewed by Cursor Bugbot for commit eedff66. Bugbot is set up for automated code reviews on this repo. Configure here.