feat(ramps-controller): send MetaMask client identity on on-ramp fetches - #9963
Draft
amitabh94 wants to merge 1 commit into
Draft
feat(ramps-controller): send MetaMask client identity on on-ramp fetches#9963amitabh94 wants to merge 1 commit into
amitabh94 wants to merge 1 commit into
Conversation
Enable catalog gating by attaching optional product, app version, and RFFC environment headers without overloading the controller query param. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
UB2 catalog gating needs product, app SemVer, and RC vs store on every on-ramp request. Other product APIs already send
x-metamask-clientproduct/x-metamask-clientversion; Client Config usesenvironmentas a query. This PR adds optional constructor fields onRampsServiceandTransakServiceand sends all three as headers.controllerstays the ramps-controller package version (JWT).clientEnvironmentis a flag dimension (prod/rc/exp/dev/ …), not an API-host switch.NeoBankService/WalletRegistrationServiceare not onmainyet. Those callers should get the same options when they land.References
Checklist
Made with Cursor