fix: retrofit full WAI-ARIA keyboard support into Tabs component (#24) - #185
Open
rafaio1 wants to merge 1 commit into
Open
fix: retrofit full WAI-ARIA keyboard support into Tabs component (#24)#185rafaio1 wants to merge 1 commit into
rafaio1 wants to merge 1 commit into
Conversation
…geFi#24) - Add role=tablist/tab, aria-selected, aria-controls/id pairing for screen readers - Implement roving tabindex: only active tab has tabIndex=0, others -1 - Arrow Left/Right navigates between tabs with wrapping; Home/End jump to first/last - Automatic activation on focus per WAI-ARIA recommended pattern for dashboards - Preserve existing visual styling and count badge behavior unchanged - All call sites continue to work without API changes TypeScript compiles cleanly with npx tsc --noEmit.
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24.
role=tablist/role=tab,aria-selected, andaria-controls/idpairing for correct screen reader announcementstabIndex=0, all others havetabIndex=-1so Tab key enters/exits the tablist onceTypeScript compiles cleanly with
npx tsc --noEmit.