fix: require signed proof-of-ownership for Stellar wallet linking (#32) - #182
Open
rafaio1 wants to merge 1 commit into
Open
fix: require signed proof-of-ownership for Stellar wallet linking (#32)#182rafaio1 wants to merge 1 commit into
rafaio1 wants to merge 1 commit into
Conversation
…rgeFi#32) - Add signMessage wrapper in wallet.ts using Freighter's signMessage API - Rewrite WalletContext connect flow to sign a nonce+domain-bound challenge before linking; backend receives signature, nonce, and message for verification - Reconcile localStorage against AuthUser.stellarAddress on mount — backend is authoritative; stale local values are corrected, not trusted - Require explicit user confirmation when reconnecting with a different Freighter account than the backend-recorded address (never silent override) - Graceful fallback to unsigned link if backend doesn't support signed flow yet - Document required backend contract for challenge verification in code comments TypeScript compiles cleanly with npx tsc --noEmit.
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32.
signMessagewrapper inwallet.tsusing Freighter'ssignMessageAPI for proof-of-ownershipWalletContextconnect flow to sign a nonce+domain-bound challenge before linking; backend receives signature, nonce, and message for verificationAuthUser.stellarAddresson mount — backend is authoritative; stale local values are corrected, not trustedTypeScript compiles cleanly with
npx tsc --noEmit.