fix: validate PoolDepositButton and MilestoneFundButton amounts with parseMoneyInput (#69) - #173
Open
rafaio1 wants to merge 1 commit into
Open
fix: validate PoolDepositButton and MilestoneFundButton amounts with parseMoneyInput (#69)#173rafaio1 wants to merge 1 commit into
rafaio1 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69.
parseMoneyInput(raw, asset)helper toutils.tsthat validates and normalizes user-entered monetary amounts: rejects empty, non-numeric, zero, negative, Infinity, NaN, and over-precision values; returns a normalized fixed-decimal string (2 decimals for USDC, 7 for XLM).PoolDepositButtonto useparseMoneyInputon every change to drive inline disabled state and error messaging, and send the normalized amount to the backend instead of the raw input string.MilestoneFundButton(from MilestoneFundButton has no amount input, making partial milestone funding impossible from the UI #83) to use the same shared validator instead of its ad-hoc inline checks, ensuring consistent validation across both money-moving inputs.assetprop onPoolDepositButton(defaults to USDC) so precision limits match the pool's actual asset type.npx tsc --noEmit.