fix: clamp completionRate and onTimeDeliveryRate in adaptReputation using coerceFraction (#91) - #168
Open
rafaio1 wants to merge 1 commit into
Open
fix: clamp completionRate and onTimeDeliveryRate in adaptReputation using coerceFraction (#91)#168rafaio1 wants to merge 1 commit into
rafaio1 wants to merge 1 commit into
Conversation
…sing coerceFraction (MergeFi#91)
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91.
coerceFractioninadapters.tsand use it to clamp bothcompletionRateandonTimeDeliveryRateafter dividing by 100, preventing out-of-range backend values (e.g. "150" or negative) from producing impossible displayed percentages like "150%" or "-20%".1(clamped), a negative value produces0, and a normal in-range value like "94" continues to produce0.94with no regression.adaptBounty,adaptMilestone, andadaptMaintenancePoolfor similar unclamped fraction derivations — none found; these two fields inadaptReputationwere the only instances where a percentage string was divided by 100 without subsequent clamping.npx tsc --noEmit.