fix: gate bounty claiming on linked payout wallet (#72) - #165
Open
rafaio1 wants to merge 1 commit into
Open
Conversation
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72.
handleClaimthat checksuser.stellarAddressbefore allowing the claim API call to proceed. If no payout wallet is linked, the action is blocked client-side with a clear error message explaining why (automatic payout release has no manual recovery path) and the user is redirected to/connectto link one.if (!user)auth gate pattern already present in the same function, and parallels thewithWalletguard used byhandleFund— but correctly checks the durable backend-linked address (user.stellarAddress) rather than requiring a live Freighter session at claim time, since those are different requirements at different points in the flow.errordisplay channel, which is visually distinct from thepending(in-flight) state per the component's current UX contract.BountyStatushas no state representing 'claimed but contributor has no payout wallet.' A soft warning would allow contributors to create an unrecoverable dead-end state where funds have nowhere to go after merge. Until a manual recovery flow or new status exists, preventing the action entirely is the safer default.npx tsc --noEmit.