fix(scripts): support Vec<(Address, u32)> in invoke.mjs parseArg - #180
Open
rafaio1 wants to merge 1 commit into
Open
fix(scripts): support Vec<(Address, u32)> in invoke.mjs parseArg#180rafaio1 wants to merge 1 commit into
rafaio1 wants to merge 1 commit into
Conversation
The release() contract function accepts recipients as Vec<(Address, u32)>, but parseArg() only handled scalar types (address, u32, i128). This made it impossible to invoke release or release_issue from the CLI. Adds vec-tuple-address-u32 type that parses a JSON array of [address, bps] pairs and encodes them as the correct Soroban ScVal tuple vector. Usage: node scripts/invoke.mjs release issue_id 'vec-tuple-address-u32:[["GADDR...",5000],["GADDR...",5000]]' Closes MergeFi#156
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #156
Problem
scripts/invoke.mjs'sparseArg()function only handles three scalar argument shapes (address,u32,i128). Therelease()contract function acceptsrecipientsasVec<(Address, u32)>, making it impossible to invokereleaseorrelease_issuefrom the CLI.Fix
Adds a
vec-tuple-address-u32type handler that parses a JSON array of[address, bps]pairs and encodes them as the correct SorobanScValtuple vector usingnativeToScVal.Usage
node scripts/invoke.mjs release issue_id 'vec-tuple-address-u32:[["GADDR...",5000],["GADDR...",5000]]'Testing