fix(github): restrict POST /github/sync/:owner/:repo with auth, roles, allowlist and throttling (#62) - #75
Open
ghzhost wants to merge 1 commit into
Conversation
…, allowlist and throttling (MergeFi#62)
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #62.
Problem
Previously,
POST /github/sync/:owner/:repowas unauthenticated and had no allowlist or role checks, allowing anyone to trigger expensive sync operations against arbitrary public GitHub repositories. Because GitHub REST API rate limits are shared platform-wide across the singleGITHUB_API_TOKEN(5,000 req/hr), an attacker could exhaust the quota on unrelated repositories and cause legitimate syncs to fail withGithubSyncInterruptedError.Solution
JwtAuthGuard& Role gating):POST /github/sync/:owner/:repobehind@UseGuards(JwtAuthGuard)and@ApiBearerAuth().MAINTAINER,SPONSOR, oradminroles, preventing unauthorized users from triggering syncs.findRepositoryByOwnerAndName(owner, repo)inGithubSyncService.repositoriestable before proceeding with sync; untracked repositories return404 Not Found.@Throttle({ default: { limit: 5, ttl: 60_000 } })to ensure the endpoint has a strict request budget tailored to its high downstream cost.src/github/github.controller.spec.tscovering role rejection (403 Forbidden), untracked repository rejection (404 Not Found), and successful sync dispatch for maintainers and sponsors.Acceptance Criteria Checklist
POST /github/sync/:owner/:reporequires authentication and maintainer/sponsor role.