feat: Add pagination to list endpoints (closes #63) - #73
Open
senmalong wants to merge 1 commit into
Open
Conversation
- Add standard limit/offset pagination to GET /bounties, /milestones, /maintenance-pools, and /users - Implement PaginationQueryDto with default page size of 50 and enforced maximum of 100 - Return paginated responses with metadata (page, limit, totalItems, totalPages, hasNextPage, hasPreviousPage) - Add comprehensive e2e tests verifying pagination behavior across all four endpoints - Ensure backward compatibility by making pagination parameters optional with sensible defaults - Order results by createdAt DESC for consistent pagination This resolves the unbounded query issue where list endpoints returned entire tables in a single response, preventing performance degradation as the platform scales.
|
@senmalong is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements standard limit/offset pagination for the four primary list endpoints that were returning unbounded result sets:
Changes
Core Implementation
Response Format
{ "data": [...], "meta": { "page": 1, "limit": 50, "totalItems": 250, "totalPages": 5, "hasNextPage": true, "hasPreviousPage": false } }Testing
Acceptance Criteria Met
✅ All four endpoints accept and apply limit/offset parameters
✅ Enforced maximum page size of 100 that cannot be bypassed
✅ Comprehensive tests prove pagination caps large result sets
✅ Backward compatible - pagination parameters optional with defaults
Related Issues
Closes #63
Notes
Ready for review!