fix(bounties): change Bounty.issue onDelete from CASCADE to RESTRICT (#53) - #71
Open
ghzhost wants to merge 1 commit into
Open
fix(bounties): change Bounty.issue onDelete from CASCADE to RESTRICT (#53)#71ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
…ergeFi#53) - Update Bounty.issue relation onDelete to 'RESTRICT' to prevent accidental hard deletion of active/funded/merged bounties when an issue is deleted - Add migration BountyIssueFkRestrict1784600000000 replacing live FK constraint with RESTRICT - Add integration test asserting DB refuses deletion of an issue attached to an active bounty
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #53.
Changes
Bounty.issuerelation on delete action fromCASCADEtoRESTRICT, aligning with the financial record integrity architecture established across the platform (Payment -> EscrowRESTRICT,Escrow -> BountySET NULL).Changes Made
Bounty.issueinsrc/common/entities/bounty.entity.tsto useonDelete: 'RESTRICT'.BountyIssueFkRestrict1784600000000insrc/database/migrations/1784600000000-BountyIssueFkRestrict.tsusing the dynamic constraint introspection helper (replaceForeignKeyOnDelete) to drop and recreate the FK constraint withON DELETE RESTRICT.src/database/escrow-fk-integrity.integration.spec.tsasserting that attempting to delete an issue linked to an active bounty is refused by Postgres due to the RESTRICT constraint.Verification
npm run buildsuccessfully (Nest CLI compilation passes).npm test/jest).