fix(teams): change TeamMemberSplit.user onDelete from CASCADE to RESTRICT (#58) - #70
Open
ghzhost wants to merge 1 commit into
Open
fix(teams): change TeamMemberSplit.user onDelete from CASCADE to RESTRICT (#58)#70ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
…RICT (MergeFi#58) - Update TeamMemberSplit.user relation onDelete to 'RESTRICT' to preserve team percentage invariants - Add migration TeamMemberSplitFkRestrict1784500000000 replacing FK constraint with RESTRICT - Add unit tests for TeamsService covering team creation, validation and bounty assignment
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #58.
This PR fixes a critical data-integrity gap where used . When a account was deleted, TypeORM/Postgres would cascade the deletion to remove their row outright, silently leaving the remaining team splits summing to less than 100%. Subsequent calls to would pass the invalid splits to , causing to throw a and stranding the bounty permanently in with a escrow.
Changes Made
Deletion Policy Trade-off Analysis
Validation