fix(milestones): validate issue repository matches milestone repository in addIssue (#59) - #69
Open
ghzhost wants to merge 1 commit into
Conversation
…ry in addIssue (MergeFi#59) - Reject cross-repository issue attachment with BadRequestException including both repository IDs - Add unit tests verifying same-repository attachment, cross-repository rejection, and not-found handling - Closes MergeFi#59
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #59 by ensuring that
MilestonesService.addIssuevalidates whether the attachedIssuebelongs to the same repository as the targetMilestone.Problem
Previously,
addIssuedirectly updatedissue.milestoneIdwithout comparingissue.repositoryIdtomilestone.repositoryId. This allowed cross-repository issue attachment, which subsequently led to unintended budget dilution inresolveIssue's proportional distribution calculation.Solution
MilestonesService.addIssue, checkif (issue.repositoryId !== milestone.repositoryId).BadRequestExceptionidentifying both repository IDs when a mismatch occurs:Issue <issueId> (repository: <issueRepo>) does not belong to Milestone <milestoneId> repository (<milestoneRepo>).repositoryIdmatches.BadRequestExceptionwhenrepositoryIddoes not match.NotFoundExceptionwhen the requested issue is missing.Closes #59