fix(users): protect GET /users and /users/:id with auth and redact PII (#64) - #68
Open
ghzhost wants to merge 1 commit into
Open
fix(users): protect GET /users and /users/:id with auth and redact PII (#64)#68ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
MergeFi#64) - Add JwtAuthGuard to UsersController to require authentication across all endpoints - Add UserResponseMapper (toPublicUser) DTO serializer pattern to strip email and sensitive fields - Expose email only to the owner (matching userId) or administrative roles - Add unit tests for UserResponseMapper and UsersController
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #64 by enforcing authentication and scoped PII serialization across
GET /usersandGET /users/:id.Changes
@UseGuards(JwtAuthGuard)and@ApiBearerAuth()at theUsersControllerclass level so thatGET /usersandGET /users/:idrequire valid authentication.UserResponseMapper(toPublicUserinsrc/users/user-response.mapper.ts) following thetoPublicEscrowmapper pattern. Sensitive PII such asemailis stripped for arbitrary callers and only preserved for the profile owner (user.id === caller.userId) or admins/maintainers.src/users/user-response.mapper.spec.ts: verifies redaction rules, owner visibility, admin visibility, and nested GitHub account serialization.src/users/users.controller.spec.ts: verifies controller-level redaction for list and findOne operations.Closes #64