fix(reputation,analytics): compute contributor earnings from payment ledger (#57) - #65
Open
ghzhost wants to merge 1 commit into
Open
fix(reputation,analytics): compute contributor earnings from payment ledger (#57)#65ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
…ledger (MergeFi#57) - Query confirmed Payment records by recipientId instead of summing full Bounty.amount - Extract shared helper computeContributorTotalEarnings for reputation and analytics - Register Payment entity in ReputationModule and AnalyticsModule - Calculate topClients in AnalyticsService by summing actual confirmed payments grouped by sponsorId - Add unit test suites for ReputationService and AnalyticsService verifying team split behavior
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #57 by computing a contributor's lifetime and total earnings directly from confirmed records in the
Paymentledger, rather than usingBounty.amount(full bounty face value).Changes
contributor-earnings.util.ts):computeContributorTotalEarnings(paymentRepo, recipientId)which queriesCOALESCE(SUM(payment.amount), 0)wherepayment.recipientId = :recipientIdandpayment.status = CONFIRMED.reputation.service.ts):paymentRepovia@InjectRepository(Payment).computeAndSaveto usecomputeContributorTotalEarningsfortotalEarnings.analytics.service.ts):paymentRepovia@InjectRepository(Payment).forContributorto usecomputeContributorTotalEarningsforlifetimeEarnings.topClientscomputation to sum confirmed payments received by the contributor grouped byescrow.sponsorId.reputation.module.ts,analytics.module.ts):Paymententity inTypeOrmModule.forFeature.reputation.service.spec.tsandanalytics.service.spec.tstesting team split calculation vs full bounty amount.Testing
npm run buildcompleted successfully with zero TypeScript compilation errors.npm test -- --testPathIgnorePatterns=integrationpassed (18 test suites, 114 tests).