fix(teams): guard assignToBounty against invalid status and claimed bounties (#41) - #50
Open
ghzhost wants to merge 1 commit into
Open
fix(teams): guard assignToBounty against invalid status and claimed bounties (#41)#50ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
…ounties (MergeFi#41) - Enforce bounty status check in TeamsService.assignToBounty: allow assignment only in OPEN or FUNDED states - Prevent assignment if the bounty has already been claimed by a contributor (bounty.claimedById) - Add comprehensive unit tests in src/teams/teams.service.spec.ts covering status guards and claim protections
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #41.
Problem
TeamsService.assignToBountyallowed attaching a team to a bounty regardless of its current state (CLAIMED,IN_REVIEW,MERGED, etc.) and even after an individual contributor had already claimed it. BecausemarkMergedAndReleaseprioritizesbounty.teamIdoverbounty.claimedById, an attacker could assign a malicious team before merge and hijack the bounty payout.Changes
TeamsService.assignToBounty:OPENorFUNDED.BadRequestExceptionif the bounty status is notOPENorFUNDED.BadRequestExceptionifbounty.claimedByIdis already set.src/teams/teams.service.spec.tscovering:OPENandFUNDEDstates without a claim.CLAIMEDstatus.IN_REVIEWstatus.claimedByIdset.Validation
npm run testpasses unit tests (18 test suites, 118 tests passed).npm run lintand Prettier format pass cleanly.npm run buildsucceeds with zero errors.