fix(users): authorize stellar-address updates by caller ID (#39) - #49
Open
ghzhost wants to merge 1 commit into
Open
fix(users): authorize stellar-address updates by caller ID (#39)#49ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
- Validate that authenticated user (req.user.userId) matches the URL :id param - Throw 403 ForbiddenException when caller attempts to update another user's stellar address - Add unit tests for UsersController verifying authorized updates and 403 rejections
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #39.
Problem
PATCH /users/:id/stellar-addresshadJwtAuthGuardapplied but lacked authorization validation. Any authenticated user could supply another user's:idin the URL param and overwrite theirstellarAddress, creating an IDOR vulnerability where bounty payouts could be redirected to an attacker's wallet.Changes
AuthenticatedRequestinterface typingreq.user({ userId, username }).UsersController.setStellarAddress, injected@Req() req: AuthenticatedRequestand added an authorization guard verifyingreq.user?.userId === id. If mismatch, throws403 ForbiddenException.src/users/users.controller.spec.tscovering:userIdmatches the:idparam.userIddiffers from the target:idparam.Validation
npm run testpasses unit tests.npm run lintand Prettier format pass cleanly.npm run buildsucceeds with zero errors.