fix: route splitRelease response through toPublicPayments - #125
Open
Gabrielcafens wants to merge 1 commit into
Open
fix: route splitRelease response through toPublicPayments#125Gabrielcafens wants to merge 1 commit into
Gabrielcafens wants to merge 1 commit into
Conversation
EscrowController's fund/findOne/release/refund all wrap their result in toPublicEscrow before it reaches an HTTP client. splitRelease was the one exception, returning the raw Payment[] entities straight from the ORM with no mapping step. Payment doesn't carry anything as sensitive as Escrow.metadata today, so this wasn't an active leak, but it left the same controller inconsistent with the pattern every other endpoint follows -- any field later added to Payment for internal bookkeeping would leak by default here with nothing to catch it in review. Adds toPublicPayment/toPublicPayments as a thin passthrough today, matching toPublicEscrow's shape, and routes splitRelease through it. Fixes MergeFi#91
|
@Gabrielcafens is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91
EscrowController's
fund,findOne,release, andrefundall wrap their result intoPublicEscrowbefore it reaches an HTTP client.splitReleasewas the one exception, returning the rawPayment[]entities straight from the ORM with no mapping step.Paymentdoesn't carry anything as sensitive asEscrow.metadatatoday, so this wasn't an active leak — but it left the controller inconsistent with the pattern every other endpoint follows, per the issue.toPublicPayment/toPublicPaymentsin a newpayment-response.mapper.ts, thin passthrough today, same shape astoPublicEscrowsplitReleasethrough itpayment-response.mapper.spec.tsfollowing the same test pattern asescrow-response.mapper.spec.tsnest buildand the fullsrc/escrowtest suite (38 tests) pass.