Only install {survMisc} when calculating test coverage - #377
Merged
Merged
Conversation
Collaborator
Author
|
{testthat} output in test coverage log showing zero skipped tests: |
yihui
approved these changes
Sep 14, 2026
yihui
left a comment
Collaborator
There was a problem hiding this comment.
From what I can tell,
R CMD checkcreates a temporary directory that only contains packages that are explicitly listed inImports/Suggests/etc.
Yes, that's true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor follow-up to my previous PR #370 that dealt with the archived package {survMisc} (#359). In that PR I used the
Config/Needsstrategy to install {survMisc} only in our CI runs. The goal was to continue to run these tests during development while avoiding any problems with CRAN policies.However, while I had confirmed that {survMisc} was installed, I had missed that the tests were still skipped in the
R CMD checkworkflow. After some troubleshooting both locally and in GitHub Actions, it is my understanding that this is a fundamental limitation ofR CMD check, and not a shortcoming of egr-lib/actions/check-r-package. From what I can tell,R CMD checkcreates a temporary directory that only contains packages that are explicitly listed inImports/Suggests/etc. Thus even though {survMisc} was installed, it was not available to {testthat} running inside ofR CMD check.However, since our coverage pipeline directly runs
covr::package_coverage(), it does run those tests, which I feel is sufficient. To make it clear that the {survMisc}-related tests are only being run in the coverage workflow, I have updatedDESCRIPTIONand the workflow files accordingly.