fix(toolbar): the temporary-session chip is drawn as the menu buttons beside it (v0.17.2) - #319
Merged
Merged
Conversation
Deploying cozy-loop-studio with
|
| Latest commit: |
11e5929
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e8e0b07c.cozy-loop-studio.pages.dev |
| Branch Preview URL: | https://fix-session-chip-size.cozy-loop-studio.pages.dev |
… beside it (v0.17.2) The Temporary session chip in the toolbar was a 20 px pill with 10 px text next to 28 px menu buttons, and its grey ink on the overlay colour read as a status badge. It is a control that opens a menu, so it is now drawn as the menu buttons are: 28 px tall, the 8 px control radius, 12 px text and 12 px of side padding, centred on the same line, the primary ink on the raised face, the menu buttons' hover boundary and their focus. It keeps its orange (warning) border at rest, its label, its accessible name and its menu; no icon and no new colour are added, and nothing in how sessions switch or save changes (CSS only; no component or store code is touched). - src/index.css: `.session-chip__btn` takes `--text-primary` and `--surface-raised`, and joins `.btn` in the focus block (the boundary takes `--line-focus` with the `--focus-halo`, and the forced-colours outline); its hover rule already used `--line-control-hover`. The revision chip keeps its own pill. - Contrast, measured in light and dark: text on face 15.59:1 and 10.88:1, the same as the menu buttons; the orange boundary 4.74:1 on the face and the toolbar in light, 4.89:1 on the face and 5.78:1 on the toolbar in dark. Hovered, opened or focused, the boundary is the menu buttons' hover or focus colour, as it is for them. - Measured in a real browser in all 18 languages: at 1280 and 721 px (the narrowest desktop width) the chip is 28 px tall at the same top as the Templates button, radius 8 px, 12 px text, one line, nothing clipped, no horizontal scroll; widths 74 px (zh-Hans) to 146 px (it). The phone layout (390 and 320 px) has no toolbar chip; its reminder in the More sheet measures exactly as before in every language. - Because the chip is wider, the toolbar's overflow sends one or two more groups to More at some widths between 800 and 1024 px (for example en at 800 px: 3 inline groups -> 2); the toolbar keeps its height. - e2e/storage-sessions.spec.ts pins it: the chip's height, radius, text size, ink and face equal the Templates button's, the same centre line, one line of text, no icon, the warning colour as the border (not the button's), the accessible name "Temporary session", and the keyboard path (Enter opens, ArrowDown enters, Escape closes and returns a visible focus with the focus boundary and halo). - Declared user-facing: version 0.17.2 and release note release:0.17.2 with three lines in 18 languages (16 without native review). The per-language copy tests move their pinned counts by the three keys, as each release does; pt-PT words two of the lines in its own way, ru spells скруглёнными with ё, vi keeps `menu` as in earlier lines.
MerciHanrim
force-pushed
the
fix/session-chip-size
branch
from
October 5, 2026 02:59
31fd6ab to
11e5929
Compare
MerciHanrim
added a commit
that referenced
this pull request
Oct 5, 2026
…n UI (#320) The three images the README shows predated the shared icons (#298), the storage gate and temporary sessions (#297) and the Temporary session button's new look (#319); they are reshot from the production UI (v0.17.2 · build 7d40cdf, on the production deployment's deploy-hash origin, byte-identical to production), each in a fresh browser context with every other origin blocked, at the same 1600 x 900 size, light theme and English as before. hero-coffee.png is taken in a temporary session, so the orange-bordered Temporary session button shows, and its alt text now says so; gacha-overview.png and gacha-pickup-guarantee.png are a personal browser, the same scenes as before, and their alt text still describes what is on screen. File names, places in the README and sizes are unchanged; the two images in docs/assets that the README does not use are left as they are. No app code, version or release note changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Temporary session chip in the toolbar was a 20 px pill with 10 px text beside 28 px menu buttons, and its grey ink on the overlay colour read as a status badge. It is a control that opens a menu, so it is now drawn as they are. Version 0.17.2, with a release note.
What changes
--text-secondary--text-primary, the menu buttons'--surface-overlay--surface-raised, the menu buttons'--line-focusboundary and--focus-halo--line-control-hover, as the chip already did) or focus colour, as theirs does.src/index.csschanges:.session-chip__btn, and the chip joins.btnin the focus block and its forced-colours twin. The revision chip keeps its pill, and no component or store code is touched, so nothing in how sessions switch or save changes.Contrast, light and dark
Measured in a real browser, 18 languages
Tests
e2e/storage-sessions.spec.tspins the result: the chip's height, radius, text size, text colour and face equal the Templates button's, on the same centre line; one line of text, no icon, the warning colour as its border and not the button's, its accessible name, and the keyboard path (Enter opens, ArrowDown enters the menu, Escape closes it and returns a visible focus with the focus boundary and halo).release:0.17.2, three lines in 18 languages (16 without native review). The per-language copy tests move their pinned counts by the three keys, as each release does. pt-PT words two of the lines in its own way, ru writes скруглёнными with ё, and vi keepsmenuas earlier lines do.Verification (local)
npx tsc -b, oxlint (39 warnings, the existing baseline), 3,077 unit tests and every check pass; the web, portable and PWA builds and the Cloudflare Production path build, with the third-party notices unchanged.Not in this pull request