Repository navigation
verify-module.sh journeys rung reads only journeys/<Module>.journey.json; a module that keeps one journey per file under journeys/<Module>/ gets FAULT "no journeys/<Module>.journey.json" #542
Description
File: project-bin/verify-module.sh lines 647-672 (JOURNEY="$JOURNEY_DIR/$MODULE.journey.json", the fault "journeys" "no …" branch, and the two _exec … node "$JOURNEY_RUNNER" "$JOURNEY" calls) · Toolkit: 393d253 · mxcli: v0.27.0 · Mendix: 11.14.0
Summary
journey-runner.js and validate-journeys.js read one journey per file, and the runner already takes several files
(node journey-runner.js journeys/*.journey.json, its own header line 6). A module with more than one journey
naturally ends up as:
journeys/<Module>/<J-01>.journey.json
journeys/<Module>/<J-02>.journey.json
journeys/<Module>/controls/<J-01>.control.json
verify-module.sh looks only for journeys/<Module>.journey.json. With the folder form and no top-level file the
rung is:
journeys FAULT 2 - (no journeys/<Module>.journey.json)
and its note says the golden path is "UNTESTED end-to-end", while eight journeys for that module sit one level down.
The only way through today is to copy one of them to the top-level name, which then has to be kept in sync by hand,
and the rung still proves just that one journey.
Expected
The folder form is recognised. A journey that exists is never reported as missing.
Suggested fix (ranked)
- If
journeys/<Module>.journey.jsonis absent andjourneys/<Module>/*.journey.jsonexists, walk those files.
Precedence: the single file when both exist (keeps today's behaviour), else the folder. - Group by persona. Since journey-runner.js: a journey's
personais only printed, so a role journey run under a different TEST_USER passes for the wrong reason #149 the runner marks a journey INVALID when itspersonadiffers from the signed-in
user ("one file, one run per role"). So one runner call with every file fails all but one role's journeys. Run
once per distinctpersonawithTEST_USERset to it (the password lookup the project already uses), or once per
file. Journeys with nopersonarun asTEST_USER, as now. - Positive control: run
--positive-controlper file that has a named control, or at least on one per persona.
Say in the row which files were controlled. - Report the denominator:
journeys: 6 of 8 PASS (journeys/<Module>/, 2 personas)rather than one verdict that
reads like the whole module. - Same lookup in
artifact-check/obligation-checkif they also hard-code the single file.
How to retest
A module with only journeys/<Module>/A.journey.json and B.journey.json (different personas): before, FAULT "no
journeys/.journey.json"; after, two runs, one per persona, both reported.
Activity
MendixMau commentedon Oct 23, 2026
Triage: DISCUSS track. It adds a new on-disk journey layout to a gate rung (FAULT to PASS), changes the Stage-5 artifact glob, and makes the runner run once per persona (more runner calls, longer runs). Verified.
Problem: The journeys rung in
project-bin/verify-module.shonly looks forjourneys/<Module>.journey.json. That's:674, the FAULT at:684, and the runner calls at:693and:698. The issue cites:647-672; the lines have moved since 393d253. Five skills document only the single-file contract (journey-proof.md:318,module-brief.md:171and others). The artifact rowbin/lib/artifact-manifest.tsv:99(${JOURNEY_DIR}/*.journey.json) is not recursive. Passing every file in one runner call fails all but one persona with INVALID (journey-runner.js:983-987).verify-module.shhas no lookup that maps a persona to its password.Value: Med. Modules with more than one journey get a false FAULT, or have to keep a hand-synced copy at the top level.
Options:
TEST_PASS_<persona>convention. Risk: med. Cost: M. Runtime grows with the number of personas.OTHER_SHAPE(:609-613).Recommendation: Option 1 now. Option 2 once there is a credential convention for each persona.
Decision needed from you: Do you accept
journeys/<Module>/*.journey.jsonas a second official layout, and should one verify run cover more than one persona? Reply "go option N" to build it.Generated by Claude Code
fix(verify-module, tests): portability markers on the guarded pgrep; …
Bug sweep 2026-10-26: gates, runners, doctor, lint receipt, git hooks…
MendixMau commentedon Oct 26, 2026
Fixed in #578 (squash a088b4e) for the reported FAULT: verify-module walks
journeys/<Module>/*.journey.jsonin one run when the single file is absent (the single file still wins). Running once per persona folder is on the roadmap: #579.Generated by Claude Code