fix: correct symlink path for hermes-agent plugin discovery - #2358
Open
GkreLee wants to merge 1 commit into
Open
fix: correct symlink path for hermes-agent plugin discovery#2358GkreLee wants to merge 1 commit into
GkreLee wants to merge 1 commit into
Conversation
The install script creates the symlink at $HOME/.hermes/plugins/memory/memtensor/, but hermes-agent's plugin discovery scans $HOME/.hermes/plugins/ for direct children. The extra memory/ subdirectory causes the plugin to be invisible to the host. Fix: change USER_TARGET to $HOME/.hermes/plugins/memtensor (without the memory/ prefix), matching hermes-agent's expected plugin layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The install script creates the symlink at
~/.hermes/plugins/memory/memtensor/, but hermes-agent's plugin discovery scans~/.hermes/plugins/for direct children. The extramemory/subdirectory causes the memtensor plugin to be invisible to the host.This means after every
hermes update(which restarts the gateway), the memory provider fails to load and stops recording traces.Fix
Change
USER_TARGETfrom/memtensorto${HOME}/.hermes/plugins/memtensor(without thememory/prefix), matching hermes-agent's expected plugin layout.Verification
After this fix,
find_provider_dir('memtensor')in hermes-agent correctly resolves the plugin directory, and the memory provider loads successfully on gateway restart.