Repository navigation
Merge Improve Collaborative Activity Identification - EXO-93112 - eXIP7.3.0.37 - #742
Conversation
… EXO-90478_EXO-90473 - eXIP7.3.0.37 (#692) Prior this change, task shipped no collaborative activity declaration: nothing told analytics which of the operations `TaskSavedListener` and `TaskCommentListener` record are a member's collaboration on a task (Meeds-io/analytics#476), and the operation names lived as literals in the listeners. After this commit, `analytics-collaborative-activities.json` at the root of `task-services` declares `taskCreated`, `taskUpdated`, the ten field, status and completion changes `TaskSavedListener` computes and `taskCommented`, leaving out `taskRankChanged` and the label operations; its `labels` name the "Tasks" help group in `Portlets_en.properties`, a title and one sentence. The computed names become public constants of the two listeners, used where each is set; `CollaborativeActivityDeclarationTest` expects every `*_OPERATION` constant of `TaskSavedListener` but the rank, so a new operation left undeclared fails it, and pins the label keys to the bundle. ### Testing `mvn -o -pl services test` at `de505071`: 261 tests, 0 failures. The later commits change the declaration, its test and the bundle only; the PR Build ran the module's suite at each head. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit d6774ad) (cherry picked from commit a0be8e5)
Backport evidenceSource: #721, merged on Picks (1, in order,
Adaptations: none: every pick has its source commit's patch-id. Verification: 1 of 1 picks carry their source commit's patch-id ( Level: N1, the eXip's level (Tech Spec §6.2, confirmed by the Architects Lead), restated from the source and not lowered; author ≠ approver. Merge order across the eXip's twelve backports: social, analytics and ecms first; documents after ecms; platform-private-distributions after analytics; the others in any order. The UI automation PR exoplatform/platform-qa-tribe#252 merges after them. |
|
boubaker
left a comment
There was a problem hiding this comment.
AI review — Round #1 (final, head 81effb313f)
This is the develop backport of #721, the eXip's feature/mips integration PR, approved at its head 15a609be2d. The review is scoped to diff-equivalence with that validated state, plus any conflict hunk or adaptation.
Diff-equivalence, verified
| Pick on this PR | Source commit on #721 | patch-id (git show -U0 | git patch-id --stable) |
|---|---|---|
81effb313f feat: Declare the task actions that count as collaborative activity |
15a609be2d |
equal (6a1ebfe731a6) |
- The pick is a plain commit equal to the approved head.
- The branch sits on the current
developtip (0 behind, mergeable), so there is no conflict hunk and no adaptation. - No other commit of the eXip in this repo is on
feature/mips.
Verified conform
- Reviewer's evidence: the author's comment carries Source / Picks / Adaptations / Verification / Level, and its pairing agrees with the table above.
- Body: the source's body as it reads, with its
Knowledge:,UI automation:and classification lines. Knowledge:: Meeds-io/eng-standards#805 and Meeds-io/eng-standards#1082 are open drafts, which is right until the eXip reachesdevelop.UI automation:: exoplatform/platform-qa-tribe#252, the suite PR, merges after the eXip's backports.- Title: the eXip's merge form, to land with Create a merge commit.
- Release order: free (Tech Spec §3.9 step 3).
Classification: N1, restated from the source (the eXip's level). Every pick equals its approved source and no hunk is new, so nothing here re-enters classification. It must not be auto-merged on AI review alone; author ≠ approver.
🤖 Generated with Claude Code
boubaker
left a comment
There was a problem hiding this comment.
Approved at 81effb313f, knowing it is classified N1.



eXIP 7.3.0.37 — Improve Collaborative Activity Identification
Integration PR of the eXip onto
feature/mips. The Tech Spec is note 52626. The board is project 8385: US1 to US10 (US2.01 to US2.07 included) are Tested & Validated on the eXip's acceptance server (2026-11-06); US11 is the knowledge update. The delivery task is EXO-93112.Why: Creating, updating, assigning, commenting on and completing a task, and changing its status or dates, count as collaborative activity; reordering a card and label changes do not.
How (this repo):
analytics-collaborative-activities.jsondeclares the task operations (creation, title, description, assignee, coworkers, due date, dates, priority, project, status, completion, comment) and carries the Tasks help labels.Release order: Free (step 3 of the Tech Spec §3.9).
Commits (cherry-picked from the eXip's FB
feature/experience,-x)Declared commits
None.
The FB's version commit (
Task-87990) is not part of this PR. Each pick's patch-id equals its FB commit's atfeature/experience@d6774ad100.Knowledge: Meeds-io/eng-standards#805, Meeds-io/eng-standards#1082
UI automation: exoplatform/platform-qa-tribe#252
This change is classified N1 at
15a609be2d: the eXip's level (Tech Spec §6.2, confirmed by the Architects Lead), applied to every integration PR of the eXip over its whole diff. The triggers are client-controlled input flowing into a trusted context (the browser statistics path: the server decides the space an event is stored under) and a migration (the upgrade plugin rewrites serialized portlet preferences). Its approver must be an Archi who knows it is N1, not an approval on AI review alone; author ≠ approver.🤖 Generated with Claude Code