CI verification run for microsoft/Trace#53 - #1
Open
MaxFreedomPollard wants to merge 1 commit into
Open
Conversation
apply_op broadcasts an operator over containers of Nodes, but two cases in opto/trace/broadcast.py never worked: - A tuple container raised "TypeError: 'tuple' object does not support item assignment", because the loop assigned into the tuple in place. The trailing `if isinstance(output, tuple): output = tuple(output)` was therefore unreachable. Accumulate into a list and convert back. - Keyword inputs against a Node-valued attribute of a NodeContainer tested `isinstance(v, Node)` (the output's attribute) instead of `isinstance(vv, Node)` (the keyword input), so a container passed by keyword was forwarded whole instead of being indexed by attribute, tripping the admissible-type assertion. The positional path already did the right thing. Adds regression tests covering a tuple container standalone and nested in a NodeContainer, a list and a dict; a bare Node broadcast against a tuple; the existing in-place list behaviour; and keyword inputs whose values are containers, including one mixed with a bare Node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the repo's own
Python unit testsworkflow against the branch proposed in microsoft#53. Not for merge — this fork PR exists only to produce a public CI result, since upstream workflow runs from first-time contributors require maintainer approval.