fix(DialogHost): Improve reliability of visual state monitoring - #4088
Merged
Conversation
Refactors `VisualStateMonitor` to track states via attached properties that are explicitly updated by XAML Storyboard animations. This change decouples state tracking from potentially inconsistent `VisualStateGroup.CurrentStateChanged` events. By having animations directly update the monitor's `CurrentState` attached property, the monitor now accurately reflects the visual state transitions for `DialogHost`'s open/closed animations. This enhances the robustness and reliability of asynchronous state waiting methods, such as `WaitForOpened` and `WaitForClosed`. Fixes: #4086
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
VisualStateMonitorto track states via attached properties that are explicitly updated by XAML Storyboard animations. This change decouples state tracking from potentially inconsistentVisualStateGroup.CurrentStateChangedevents.By having animations directly update the monitor's
CurrentStateattached property, the monitor now accurately reflects the visual state transitions forDialogHost's open/closed animations. This enhances the robustness and reliability of asynchronous state waiting methods, such asWaitForOpenedandWaitForClosed.Fixes: #4086