Repository navigation
clippy: late-init temp file and async_trait must_use on a newer toolchain - #8
Merged
Merged
Conversation
…hain CI's clippy (rustc 1.99) rejects two things on main: the script runner's `_colors_file` was declared and assigned later in each branch (needless_late_init), and async_trait's expansion of ThemeModule puts a bare `#[must_use]` on every async method (double_must_use), which is the macro's doing and is allowed on the trait with a note. Main's ci job had been red on these since 0.3.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's
cijob (rustc 1.99 clippy,-D warnings) has been red since 0.3.1 on two pre-existing lints in lmtt-modules:needless_late_initon the script runner's temp file (now an if/else expression) anddouble_must_useon every async method ofThemeModule, which comes from async_trait's expansion and is allowed on the trait with a note.cargo clippy --workspace --all-targets -- -D warnings,cargo fmt --checkand the lmtt-modules tests pass locally.