Repository navigation
wallpaper: unset removes a per-output override - #7
Merged
Merged
Conversation
`lmtt wallpaper set --output <sel>` had no inverse, so a settings UI could not give a display back to the global wallpaper without editing the registry itself. `lmtt wallpaper unset --output <sel>` removes that key from the user profile, writes it atomically and republishes the greeter-readable snapshot unless --no-publish; a key that is not there is reported and exits 0 with nothing rewritten. Integration test under a throwaway XDG tree: set global + two outputs, unset one, the other and the global rule survive, a second unset is a no-op that leaves the file untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to MasonRhodesDev/dials#8 (the Displays inspector's Override checkbox needs an inverse of
wallpaper set --output).lmtt wallpaper unset --output <selector> [--no-publish]: removes that key from the user appearance profile, writes it atomically with the existingwrite_profile, republishes the greeter-readable snapshot unless--no-publish. A missing key prints "No wallpaper override for …" and exits 0 with nothing rewritten (dials relies on the idempotence).error: unrecognized subcommand 'unset', exit 2, which dials reports as "lmtt too old".lmtt/tests/wallpaper_unset.rs: set global + two outputs under a tempXDG_CONFIG_HOME, unset one; the other override and[background]survive; a repeat unset leaves the file's mtime alone.Needs a 0.3.2 release once merged (version bump is the release commit).