Repository navigation
chore(app): bump vitest and @vitest/coverage-v8 to 5.0.5 - #12249
Merged
Merged
Conversation
Moves the frontend test runner from Vitest 4.1.11 to 5.0.5. No config or test changes were needed: the suite keeps its 1,168 tests and the same 117-file coverage set, and the production bundle is byte-identical in file names and sizes. @vitest/mocker 5.0.5 sits outside both open Dependabot advisory ranges (GHSA-qxg6-89mg-rqv8, GHSA-xp26-3454-mjgp), so this supersedes #12241. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0175hA62juZoajMcqKxWFGza
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0175hA62juZoajMcqKxWFGza
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Remove the PR reference from the changelog fragment to comply with the documented fragment format.
No open issues 🎉
What changed in this PR
This pull request upgrades the frontend test tooling from Vitest 4.1.11 to 5.0.5, resolving the affected @vitest/mocker advisories without changing production code.
Changes:
- Updates
vitestand@vitest/coverage-v8to^5.0.5. - Refreshes the Yarn lockfile and Vitest dependency tree.
- Adds a changelog fragment documenting the upgrade and validation results.
| File | Description |
|---|---|
changelog.d/vitest-5.md |
Documents the Vitest upgrade, advisory resolution, and compatibility validation. |
app/yarn.lock |
Locks Vitest 5.0.5 and its updated transitive dependencies. |
app/package.json |
Updates the Vitest and coverage provider development dependencies. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vitestand@vitest/coverage-v8inapp/from ^4.1.11 to ^5.0.5. Test-time dependency only; nothing ships to the site.app/yarn.locknow resolves@vitest/mocker5.0.5, which is outside both open Dependabot advisory ranges (GHSA-qxg6-89mg-rqv8< 4.1.12, GHSA-xp26-3454-mjgp>= 4.1.11, < 4.1.12).clearMocksnow defaults totrue: all 1,168 tests still pass.vi.mock/vi.hoistedinside functions ordescribeblocks now throw: none in the suite, all tests pass.coverage.include/coverage.excludelost their looser "contains" matching: the coverage file set is identical to Vitest 4 (117 files, diffed).vitebecame a required peer dependency:app/package.jsonalready listsvite8.3.5, inside the^6.4.0 || ^7.0.0 || ^8.0.0peer range.^22.12.0 || ^24.0.0: CI and the local toolchain run Node 24.Plan
N/A. A single dependency bump, no plan file.
Test plan
Local, Node 24.21.0, in a fresh worktree from
origin/main:yarn lint: passyarn fm:check: passyarn type-check: passyarn test: 106 files, 1,168 tests pass (same counts as Vitest 4.1.11 onmain)yarn test --coverage(the CI form): pass; 117 covered files, identical list to Vitest 4; statements 80.55 % vs 80.61 % onmainyarn build: pass;dist/identical tomainin file names and sizesuv run python -m tools.changelog check --base origin/main: passNo local browser run against the backend: Vitest is a test-time dependency only and never reaches the site, and the built bundle is identical to
main. The gates plus the full test run cover this change.🤖 Generated with Claude Code
https://claude.ai/code/session_0175hA62juZoajMcqKxWFGza