Repository navigation
deps(npm): Bump vite from 8.0.16 to 8.1.6 in /app - #12225
Merged
Merged
Conversation
dependabot
Bot
added
dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Owner
|
@dependabot rebase |
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 8.0.16 to 8.1.6. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v8.1.6/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.1.6/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 8.1.6 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/app/vite-8.1.6
branch
from
October 22, 2026 17:47
205c382 to
9810c3b
Compare
MarkusNeusinger
enabled auto-merge (squash)
October 22, 2026 17:48
7 tasks done
MarkusNeusinger
added a commit
that referenced
this pull request
Oct 22, 2026
…12235) ## Summary - **Production outage:** since #12225 (Vite 8.0.16 → 8.1.6), every page on anyplot.ai renders blank. Rolldown 1.1.5 places its CJS-interop runtime helper in the app's `theme` chunk, which imports `mui`, while `mui` imports the helper back. The chunk cycle leaves the helper uninitialized: `TypeError: t is not a function` at `assets/mui-*.js:1`. - Bumps `vite` to 8.3.5 (Rolldown 1.2.15), which emits the helper as a separate `rolldown-runtime` chunk with no imports, so the cycle is gone. `manualChunks` and native `codeSplitting.groups` cannot steer the runtime module (it is never offered to group matchers), so a config-only fix wasn't possible on 8.1.6. - Deduplicates `yarn.lock` so vitest's `vite@^6 || ^7 || ^8` range resolves to the same 8.3.5 instead of keeping 8.1.6. ## Test plan - [x] Reproduced the crash against prod with headless Chromium (`/`, `/scatter-basic`, `/gain-curve` all blank with the page error above). - [x] Reproduced locally with `vite build` on 8.1.6: `mui` → `theme` → `mui` import cycle in `dist/assets`. - [x] `vite build` on 8.3.5: `mui` and `vendor` import only `rolldown-runtime`, no cycle; `vite preview` of `/gain-curve` boots the app with no page error. - [x] `tsc --noEmit` passes. - [x] `vitest run`: 1166/1168 pass; the 2 failures (`fileText.test.ts`, windows-1252 decoding) fail identically on `main` in this container (Node 22.22.0, below the `jsdom` engine range), so they are environmental, not from this change. ## Checklist - [x] `changelog.d/vite-runtime-chunk-cycle.md` added - [x] Related documentation updated — not needed, no behavior change beyond the fix --- _Generated by [Claude Code](https://claude.ai/code/session_013gWuDKsb8J8uqXsHdmhHqs)_ Co-authored-by: Claude <noreply@anthropic.com>
4 of 5 tasks
MarkusNeusinger
added a commit
that referenced
this pull request
Oct 22, 2026
…merges (#12236) ## Summary - On 2026-10-22 vite 8.1.6 (#12225) passed every PR check and its deploy, and left every page on anyplot.ai blank for about 45 minutes (Rolldown chunk cycle, `TypeError: t is not a function` at module load; fixed by #12235). Nothing in CI or the post-merge routine ran the bundle. - New `scripts/site-smoke.mjs`: loads `/`, `/plots` and `/scatter-basic` in headless Chromium and fails on a status other than 200, an uncaught page error, or an empty `#root`; checks `api.anyplot.ai/health`. It never downloads a browser (CHROME_PATH, the cloud container's Chromium, or the Playwright MCP's). - **Before the merge:** the `app-image` job of `ci-image.yml` runs it against the built gate-off container with the runner's Google Chrome, whenever the container's inputs change (`package.json`, `yarn.lock`, `vite.config.ts`, ...), which is every frontend dependency bump. - **After the merge:** a new `CLAUDE.md` rule (owner request, 2026-10-22) with the recipe in `/open-pr` §4 and the Dependabot batch command: after every merge, once its deploys finish, run the smoke against production; a FAIL is an incident and stops further merges. The Dependabot command also merges lock-file PRs one at a time and smokes after each `app/` bump. The incident narrative is in `.claude/guardrails.md`. ## Plan N/A. The owner asked on 2026-10-22, after the outage, for a rule or skill so a blank site never goes unnoticed again. ## Test plan - [x] Local app image built like CI (`VITE_API_URL=https://api.anyplot.ai`), gate-off container on :8081, `SITE=http://localhost:8081 API=none MIN_TEXT=50 node scripts/site-smoke.mjs /`: OK (`text=2736`, one CORS console error reported as a warning) - [x] Same against an image built from 20c1457 (vite 8.1.6, the broken state): `FAIL ... text=0 ... pageerror: t is not a function`, exit 1 - [x] Against production: all four checks OK - [x] `uv run pytest tests/unit/workflows` (766 passed), `uv run ruff check .`, changelog check - [ ] This PR's own `Build app image and smoke the origin gate` run exercises the new step on the runner (ci-image.yml changes trigger the job) - No live verification loop exists for `.github/workflows/` beyond this PR's own run; the CLAUDE.md rule has no twin in `.github/copilot-instructions.md`, which does not carry the merge routine. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01GdMSqLR5ww4ji74EUSmk9M --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps vite from 8.0.16 to 8.1.6.
Release notes
Sourced from vite's releases.
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
dade886release: v8.1.6170b927fix(server): store ids tosafeModulePathsrather than URLs (#23656)e46fc9cfix(deps): update launch-editor to v2.14.2 (#23654)4ff2522fix(html): filename passed to transformIndexHtml should not include queries (...5e7fe12release: v8.1.56c08c39fix(optimizer): respect importer module format for dynamic import interop wit...5a72b87fix(client): overlay error message format align rolldown (#22869)f8b38e3fix(module-runner): don't crash stack-trace source mapping when globalThis.Bu...8100320fix(bundled-dev): avoid duplicatedbuildEnd(#22931)c88c236docs(build): fix incorrect@defaultfor build.cssMinify (#22948)