Skip to content

feat: apply filter in overview (#301) - #322

Open
timdegroot1996 wants to merge 7 commits into
mainfrom
filter-in-overview
Open

feat: apply filter in overview (#301)#322
timdegroot1996 wants to merge 7 commits into
mainfrom
filter-in-overview

Conversation

@timdegroot1996

@timdegroot1996 timdegroot1996 commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Implements #301. Rebased/reimplemented from HuntTheSun's work (originally #314, further developed at https://github.com/HuntTheSun/robotframework-dashboard/tree/dev_pr/filter_in_overview) onto current main, since #314's branch had fallen behind.

Commits authored by @HuntTheSun (cherry-picked, unchanged):

  • feat: apply filter in overview — filter modal now applies to Overview via filteredRuns
  • dashboard/filter_modal: fix run filter selected indicator
  • feat/dashboard: add filter active dot — indicator dot on the filter icon and the Runs filter label when a filter is active
  • fix/dashboard: filter active indicator on profile load

Additional commit on top (per the design agreed in the #301 thread that wasn't yet applied):

  • Removed the per-project-bar and Latest-Runs version filter dropdowns, since the global Filter modal's version filter now covers the Overview page too, making them redundant.

Also carries forward, per the #301 discussion: the percentage dropdown moved from per-bar/per-section controls into a single Settings > Overview control, and no separate "apply global filter to Overview" toggle — filters just always apply, matching your read that not applying them by default doesn't make sense.

Status

  • JS unit tests: 256/256 pass
  • Python unit tests: 311/311 pass
  • Manually verified in a real browser: Overview renders correctly, no console errors, no leftover version-filter elements

Still needed before merge

  • Regenerate robot acceptance test reference screenshots (Overview HTML changed) — needs Docker per .github/skills/fix-robot-tests.md
  • Full robot suite run

Closes #301.

🤖 Generated with Claude Code

HuntTheSun and others added 5 commits September 14, 2026 01:29
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
The Filter Popup's version filter now applies to the Overview page as
well (from HuntTheSun's filter-in-overview work), making the separate
per-project-bar and Latest-Runs version filter dropdowns redundant, as
agreed with HuntTheSun on #301.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Typing e.g. "1." in the Filter modal's version search box now checks
every matching version checkbox (and unchecks non-matches) instead of
only narrowing which rows are visible, restoring in one step what the
removed per-project-bar version filter's text box used to do.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@timdegroot1996

timdegroot1996 commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

@HuntTheSun this is your work rebased onto current main (your dev_pr/filter_in_overview branch had drifted behind, so I cherry-picked those 4 commits over and reopened here as #322 after closing #314). Wanted to flag what's different from what you have on your dev/dev_pr/filter_in_overview branches so you can weigh in before we merge:

Unchanged from your work:

  • Filter applies in Overview via filteredRuns
  • Percentage dropdown moved to Settings > Overview
  • Filter active indicator dot on the filter icon + Runs label
  • Your two indicator bugfixes

Changed on top, per our discussion on #301:

  • Removed the per-project-bar and Latest-Runs "Select Versions" dropdowns entirely, since the global Filter modal's version filter now covers Overview too and they'd become redundant/duplicate UI.
  • To make up for what that removal took away — typing e.g. "1." in the old per-bar version box used to instantly show every 1.x run in one step — the Filter modal's own version search box now does the same thing: typing there auto-checks every matching version (and unchecks the rest) instead of just hiding non-matching rows in the dropdown.

Not included from your dev branch: the other work there (customFilter on overview cards, version-select perf fixes, Promise.all/Set refactors, pako removal, async main) — kept this PR scoped to #301 only, happy to pick those up separately if you want to open PRs for them.

Below is an example robot_dashboard.html built from this branch below so you can click through it directly. Would love your take on the version-filter removal + the auto-select replacement in particular. Let me know what you think!

robot_dashboard_example.html

…removal

Regenerate the 5 stale Overview reference screenshots (layout changed:
no more per-bar/Latest-Runs version dropdown). Remove the 3 tests that
exercised the removed per-bar version filter search box along with
their now-orphaned reference images, and add a replacement test in
06_filters.robot covering the new auto-select-on-type behavior in the
global Filter modal's version box.

Verified in Docker: 63 tests, 59 passed, 0 failed, 4 skipped.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@timdegroot1996
timdegroot1996 marked this pull request as ready for review September 14, 2026 00:16
@timdegroot1996

Copy link
Copy Markdown
Collaborator Author

Robot acceptance tests regenerated and passing in Docker: 63 tests, 59 passed, 0 failed, 4 skipped.

  • 5 Overview screenshots updated for the new layout (no per-bar/Latest-Runs version dropdown)
  • Removed the 3 tests that exercised the deleted per-bar version filter search box, plus their orphaned reference images
  • Added a test in 06_filters.robot covering the new auto-select-on-type behavior in the global Filter modal's version box

@HuntTheSun still hoping to hear your thoughts on the version-filter removal + auto-select replacement before this merges.

@HuntTheSun

HuntTheSun commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Hi,

thank you for saving me the time of creating a new PR :)

I liked the snappy-ness of filtering with the textinput version selector, but I think the new feature is very nicely done and it makes sense to consolidate.
I think it would maybe be a tad nicer if one clears the version "Filter... (selects matches)" box that I auto-reselects "All"/ deselects everything else, but simply typing "A" to do that also is very fine by me.

Other than that, the example dashboard you sent looks good to me.

Thanks again for your work :)

@HuntTheSun

Copy link
Copy Markdown
Contributor

By the way,

some of the PRs you see on the dev branch of my fork may not have been tested thoroughly enough for open-sourcing, they were just quick changes made for my specific use case.
They may be just fine to merge, but they have not been tested well nor developed with the most "care".
I will look them over and create Issues/PRs for them if I feel like they fit the use cases of others and are up to a certain quality standard.

@timdegroot1996

Copy link
Copy Markdown
Collaborator Author

@HuntTheSun thanks for the fast response!

thank you for saving me the time of creating a new PR :)

Long live AI haha, but you're welcome!

I think it would maybe be a tad nicer if one clears the version "Filter... (selects matches)" box that I auto-reselects "All"/ deselects everything else, but simply typing "A" to do that also is very fine by me.

I don't fully understand what you mean here, can you give an example with versions that are selected unselected and how it is now, and what you think would be nicer? I'm defenitely open to improving it if we can!

some of the PRs you see on the dev branch of my fork may not have been tested thoroughly enough for open-sourcing, they were just quick changes made for my specific use case.
They may be just fine to merge, but they have not been tested well nor developed with the most "care".
I will look them over and create Issues/PRs for them if I feel like they fit the use cases of others and are up to a certain quality standard.

Alright I will leave them as is then. If you feel there's improvements that are worth going into the project feel free to open the PR's/issues and we can discuss them further then!

Again, thanks for the work on this, I think we can release this very soon as well! 👍

@HuntTheSun

Copy link
Copy Markdown
Contributor

I don't fully understand what you mean here, can you give an example with versions that are selected unselected and how it is now, and what you think would be nicer? I'm defenitely open to improving it if we can!

For example, in the dashboard you uploaded, if I enter "1." three version are selected:

  • 1.2
  • 1.1
  • 0.1 (should not be included in "1." input imo, but thats a matter of taste)

When I then clear the input, so the version filter is empty again, the selection does not "reset", it stays on the last selected bunch.
In this screenshot, I cleared the version filter textinput, but the prior selection stays:

version_no_reset

Is this expected behavior or a bug?

Alright I will leave them as is then. If you feel there's improvements that are worth going into the project feel free to open the PR's/issues and we can discuss them further then!

Thank you, I will do so :)

@timdegroot1996

Copy link
Copy Markdown
Collaborator Author

@HuntTheSun oh that's very interesting. I see why this is happening now. I didn't clear the box but just left it as is. If you remove the characters 1 by 1 then this issue happens. If you select the entire box and then clear it you get the desired behavior as well.

I'm not entirely sure what a good solution would be here because how can we differentiate between "clearing to stop searching" and "clearing to search for something else". Any suggestions? Maybe a small "X" in the search bar to clear it and then it would keep the 1. 2., and not the 0.1 selection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Filter in Overview

2 participants