feat: apply filter in overview (#301) - #322
Conversation
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
The Filter Popup's version filter now applies to the Overview page as well (from HuntTheSun's filter-in-overview work), making the separate per-project-bar and Latest-Runs version filter dropdowns redundant, as agreed with HuntTheSun on #301. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Typing e.g. "1." in the Filter modal's version search box now checks every matching version checkbox (and unchecks non-matches) instead of only narrowing which rows are visible, restoring in one step what the removed per-project-bar version filter's text box used to do. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@HuntTheSun this is your work rebased onto current Unchanged from your work:
Changed on top, per our discussion on #301:
Not included from your Below is an example |
…removal Regenerate the 5 stale Overview reference screenshots (layout changed: no more per-bar/Latest-Runs version dropdown). Remove the 3 tests that exercised the removed per-bar version filter search box along with their now-orphaned reference images, and add a replacement test in 06_filters.robot covering the new auto-select-on-type behavior in the global Filter modal's version box. Verified in Docker: 63 tests, 59 passed, 0 failed, 4 skipped. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Robot acceptance tests regenerated and passing in Docker: 63 tests, 59 passed, 0 failed, 4 skipped.
@HuntTheSun still hoping to hear your thoughts on the version-filter removal + auto-select replacement before this merges. |
|
Hi, thank you for saving me the time of creating a new PR :) I liked the snappy-ness of filtering with the textinput version selector, but I think the new feature is very nicely done and it makes sense to consolidate. Other than that, the example dashboard you sent looks good to me. Thanks again for your work :) |
|
By the way, some of the PRs you see on the dev branch of my fork may not have been tested thoroughly enough for open-sourcing, they were just quick changes made for my specific use case. |
|
@HuntTheSun thanks for the fast response!
Long live AI haha, but you're welcome!
I don't fully understand what you mean here, can you give an example with versions that are selected unselected and how it is now, and what you think would be nicer? I'm defenitely open to improving it if we can!
Alright I will leave them as is then. If you feel there's improvements that are worth going into the project feel free to open the PR's/issues and we can discuss them further then! Again, thanks for the work on this, I think we can release this very soon as well! 👍 |
|
@HuntTheSun oh that's very interesting. I see why this is happening now. I didn't clear the box but just left it as is. If you remove the characters 1 by 1 then this issue happens. If you select the entire box and then clear it you get the desired behavior as well. I'm not entirely sure what a good solution would be here because how can we differentiate between "clearing to stop searching" and "clearing to search for something else". Any suggestions? Maybe a small "X" in the search bar to clear it and then it would keep the 1. 2., and not the 0.1 selection? |

Implements #301. Rebased/reimplemented from HuntTheSun's work (originally #314, further developed at https://github.com/HuntTheSun/robotframework-dashboard/tree/dev_pr/filter_in_overview) onto current
main, since #314's branch had fallen behind.Commits authored by @HuntTheSun (cherry-picked, unchanged):
feat: apply filter in overview— filter modal now applies to Overview viafilteredRunsdashboard/filter_modal: fix run filter selected indicatorfeat/dashboard: add filter active dot— indicator dot on the filter icon and the Runs filter label when a filter is activefix/dashboard: filter active indicator on profile loadAdditional commit on top (per the design agreed in the #301 thread that wasn't yet applied):
Also carries forward, per the #301 discussion: the percentage dropdown moved from per-bar/per-section controls into a single Settings > Overview control, and no separate "apply global filter to Overview" toggle — filters just always apply, matching your read that not applying them by default doesn't make sense.
Status
Still needed before merge
.github/skills/fix-robot-tests.mdCloses #301.
🤖 Generated with Claude Code