Repository navigation
Removed unused setup.py and fixed the _files docstring - #21
Merged
Merged
Conversation
- Removed setup.py, a leftover from the earlier setuptools build. The package is built with the uv_build backend, which does not use it. - Fixed the docstring of _AutotestSettings._files: it is the path of the directory where the test files were extracted, not a list of files. - Corrected the changelog entry about pinning ruff, which is now pinned in the dev dependencies and pre-commit (currently v0.17.3). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup.py. It only containedfrom setuptools import setup; setup(), a leftover from the earlier setuptools build.pyproject.tomlusesbuild-backend = "uv_build", so it was unused; nothing in the workflows,pyproject.toml, or README references it._AutotestSettings._filesdocstring. It said "A list of test files", but the field is a single string: the path of the directory where the autotester extracted these settings' test files (markus-autotesting setstest_settings["_files"] = files_dir).devdependency group and.pre-commit-config.yaml, and CI's ruff-action reads the version frompyproject.toml. Only that line was edited; no new entry, since these cleanups are not user-facing.Testing
uv sync --locked --all-extras --dev, thenuv run pytest -q: 11 passed.uv run ruff check .: all checks passed.uv run ruff format --check .: 6 files already formatted.uvx --from "uv==0.13.6" uv build -o <temp dir>: built both the sdist and the wheel withoutsetup.py; the sdist containsPKG-INFO,pyproject.toml,README.mdand thesrc/markus_autotesting_coresources, and the wheel contains the package and its dist-info.🤖 Generated with Claude Code