Skip to content

Fix CardStack search box alignment #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Incogdino merged 1 commit into from
Aug 1, 2026
Merged

Fix CardStack search box alignment #2912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/vue-components/src/__tests__/CardStack.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,19 @@ const CARDS_WITH_CUSTOM_TAGS = `
`;

describe('CardStack', () => {
test('search input should not reuse the wrapper spacing class', () => {
const wrapper = mount(CardStack, {
propsData: {
searchable: true,
},
global: DEFAULT_GLOBAL_MOUNT_OPTIONS,
});

const searchBar = wrapper.find('.search-bar');
expect(searchBar.element.tagName).toBe('SPAN');
expect(searchBar.find('input').classes()).not.toContain('search-bar');
});

test('should not hide cards when no filter is provided', async () => {
const wrapper = mount(CardStack, {
propsData: {
Expand Down Expand Up @@ -527,7 +540,7 @@ describe('CardStack', () => {
expect(wrapper.vm.tagCounts.get('Tag2')).toBe(2);

// Simulate a search for "alpha" which only matches the first card (Tag1)
const searchInput = wrapper.find('input.search-bar');
const searchInput = wrapper.find('.search-bar input');
await searchInput.setValue('alpha');
await searchInput.trigger('input');
await wrapper.vm.$nextTick();
Expand Down Expand Up @@ -710,7 +723,7 @@ describe('CardStack', () => {
expect(wrapper.vm.matchingCardsCount).toBe(3);

// Search for "alpha beta" - should match only first card
const searchInput = wrapper.find('input.search-bar');
const searchInput = wrapper.find('.search-bar input');
await searchInput.setValue('alpha beta');
await searchInput.trigger('input');
await wrapper.vm.$nextTick();
Expand Down
6 changes: 3 additions & 3 deletions packages/vue-components/src/__tests__/__snapshots__/CardStack.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ exports[`CardStack markdown in header, content 1`] = `
class="search-bar"
>
<input
class="form-control search-bar"
class="form-control"
placeholder="Search"
type="text"
/>
Expand Down Expand Up @@ -97,7 +97,7 @@ exports[`CardStack should not hide cards when no filter is provided 1`] = `
class="search-bar"
>
<input
class="form-control search-bar"
class="form-control"
placeholder="Search"
type="text"
/>
Expand Down Expand Up @@ -231,7 +231,7 @@ exports[`CardStack should not hide cards when no filter is provided 2`] = `
class="search-bar"
>
<input
class="form-control search-bar"
class="form-control"
placeholder="Search"
type="text"
/>
Expand Down
4 changes: 2 additions & 2 deletions packages/vue-components/src/cardstack/CardStack.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<input
v-model="value"
type="text"
class="form-control search-bar"
class="form-control"
:placeholder="placeholder"
@input="update"
/>
Expand Down Expand Up @@ -283,7 +283,7 @@ export default {
justify-content: center;
align-items: center;
margin: 0;
padding: 5px;
padding: 0;
}

.row {
Expand Down
Loading