Introduce CustomShellCommand with failure handlers#987
Open
RazvanLiviuVarzaru wants to merge 1 commit into
Open
Introduce CustomShellCommand with failure handlers#987RazvanLiviuVarzaru wants to merge 1 commit into
RazvanLiviuVarzaru wants to merge 1 commit into
Conversation
Motivation: MDBF-916: Buildbot's MTR step is deprecated in newer releases. Folding related tasks, such as saving logs and publishing MTR results to CrossReference, into one step reduces UI clutter. Description: Replace ShellCommandWithURL while retaining rendered artifact URLs. Run named commands after a primary failure without masking it, while propagating exceptions, retries, and cancellations. Support Buildbot 2.7 and 4.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
MDBF-916: Buildbot's MTR step is deprecated in newer releases. Folding related tasks, such as saving logs and publishing MTR results to CrossReference, into one step reduces UI clutter.
Description:
Replace ShellCommandWithURL while retaining rendered artifact URLs. Run named commands after a primary failure without masking it, while propagating exceptions, retries, and cancellations. Support Buildbot 2.7 and 4.x.
@fauust / @grooverdan let me know if this sounds like a good idea to you. A yes means that I will start refactoring the bb code to use the new class and remove any
MTRbb step usage.