Drop a pages check that compared against a file nobody publishes - #3
Merged
Conversation
The first pages deploy failed on the drift check added with the site, and the check was wrong on both assets it looked at. meridian.css returned 404. In marstack-cloud, -secrets and -access that file is gitignored and generated by `make site` from internal/console/assets, so no published copy exists to diff against. site.css fetched but compared unequal, because command substitution strips the trailing newline and `printf '%s'` does not put it back — a hash difference about newlines, not about content. Patching the newline would leave a step that appears to guard two stylesheets while only reaching one, so the step goes. That leaves the vendored theme unguarded, and it is worth being plain about why: this repository has to commit meridian.css because it is a CLI with no console to generate it from, and the real source is the separate marstack-theme module. Nothing checked into this repository can tell whether that module has moved on. A hash pinned here would only catch someone editing the vendored copy by hand, which is not the failure worth a CI step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first pages deploy after #2 failed on the theme drift check that shipped with the site. The check was wrong on both assets.
meridian.cssreturned 404: inmarstack-cloud,-secretsand-accessit is gitignored and generated bymake site, so there is no published copy to diff against.site.cssfetched but compared unequal, because command substitution strips the trailing newline andprintf '%s'does not restore it — a newline difference, not content.Patching the newline would leave a step that reads as guarding two stylesheets while reaching one, so the step goes.
That leaves the vendored theme unguarded. Worth stating plainly: this repo must commit
meridian.cssbecause it is a CLI with no console to generate it from, and the real source is the separatemarstack-thememodule. Nothing in this repository can tell whether that module has moved on.Note that
pages.ymlonly runs onmain, so this fix cannot be validated by CI on the PR — the deploy is the test.