[pmeems]

Completes Phase 1 by separating the Core and ActiveX CTest suites, checking that the activation filter selects a test, and enabling /WX across configurations and platforms. Adds CMake Win32 Debug coverage to pull-request CI and updates build/testing documentation.

Validation:

• CMake x64 Debug (Visual Studio and Ninja) and Win32 Debug builds and non-interactive CTest suites pass.
• CMake x64 Release full-driver tests pass, including GdalEnvironment.IncludesTheReleaseDriverSet and the registered-control activation check.
• MSBuild Debug x64 builds cleanly; both native test executables pass.
• The Core-only CMake configuration and the activation script's zero-test negative check pass.
• Compare-CompileCommands.ps1 -FailOnLostFlags -FailOnNewWarnings passes with zero lost flags and zero CMake warnings. Its incremental MSBuild rebuild emitted two MSB3061 access-denied warnings while replacing runtime DLLs; the standalone MSBuild build reported zero warnings.

The review HTML referenced by the plan was unavailable at the checked paths; implementation followed the written Phase 1 criteria and source verification.

[Copilot]

🟡 Changes recommended

The unlabeled direct-discovery hosting test remains selected by non-interactive runs and, when MWG_TEST_ACTIVEX_HOST is inherited, can activate the wrong registered OCX or fail without the script’s registration setup.

1 open issue

• Exclude the ActiveX test from non-interactive discovery · New

What changed in this PR

This PR advances MapWinGIS6’s CMake migration by separating Core and ActiveX test suites, strengthening activation-test validation, and aligning warning enforcement across build systems.

Changes:

• Adds a dedicated ActiveX CMake test target while keeping Core tests available without ActiveX.
• Rejects activation runs that select no tests and enables /WX across configurations and platforms.
• Adds Win32 Debug pull-request CI coverage and updates build/testing documentation.

Builds and tests were not run during this review.

File	Description
tests/​MapWinGIS.Core.Tests/​CMakeLists.txt	Removes ActiveX dependencies and enables full-driver test coverage.
tests/​MapWinGIS.ActiveX.Tests/​Verify-ActiveXActivation.ps1	Checks the GoogleTest report for selected tests and cleans it up.
tests/​MapWinGIS.ActiveX.Tests/​CMakeLists.txt	Adds the ActiveX test executable, discovery, and interactive activation entry.
src/​MapWinGIS.ActiveX/​CMakeLists.txt	Clarifies a Windows-dependency comment; no functional change.
README.md	Documents independent test suites and expanded CI coverage.
docs/​TESTING.md	Updates CTest and activation-verification guidance.
docs/​CMAKE-MIGRATION.md	Records separate test targets, dependencies, and warning settings.
docs/​BUILDING.md	Documents ActiveX CMake tests and Core-only configurations.
CMakeLists.txt	Registers Core tests independently and ActiveX tests conditionally.
cmake/​MwgCompilerOptions.cmake	Enables /WX for all CMake configurations and platforms.
build/​scripts/​Compare-CompileCommands.ps1	Accounts for ActiveX test include-path differences in parity checks.
build/​props/​MapWinGIS.Cpp.props	Enables warnings-as-errors across MSBuild configurations and platforms.
AGENTS.md	Updates validation guidance for CMake’s ActiveX test support.
.gitignore	Ignores local tooling and PowerShell editor state.
.github/​workflows/​build.yml	Adds CMake Win32 Debug coverage for pull requests.

_{Review effort: Balanced}

[Julian-MW]

Automated review. Final decision is with the human reviewer.